Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): hide rows cols should skip over already hidden ranges #2517

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 14, 2024

close #2088

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from DR-Univer as a code owner June 14, 2024 01:32
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.17%. Comparing base (ca76011) to head (4da30d0).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2517      +/-   ##
==========================================
+ Coverage   27.16%   27.17%   +0.01%     
==========================================
  Files        1653     1653              
  Lines       83357    83380      +23     
  Branches    17263    17272       +9     
==========================================
+ Hits        22642    22660      +18     
- Misses      60715    60720       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jun 14, 2024
@wzhudev wzhudev merged commit 1896852 into dev Jun 18, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix/hidden-rows-cols branch June 18, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After undo is set to hide a row, the status of the hidden row is incorrect.
3 participants