Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sheet): format-painter supports adding hooks to extend command #2505

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz changed the title refactor(sheet): format painter supports hooks refactor(sheet): format-painter supports hooks Jun 13, 2024
@yuhongz yuhongz changed the title refactor(sheet): format-painter supports hooks refactor(sheet): format-painter supports hooks to extend mutations Jun 13, 2024
@yuhongz yuhongz changed the title refactor(sheet): format-painter supports hooks to extend mutations refactor(sheet): format-painter supports adding hooks to extend mutations Jun 13, 2024
@yuhongz yuhongz changed the title refactor(sheet): format-painter supports adding hooks to extend mutations refactor(sheet): format-painter supports adding hooks to extend command Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 88.79310% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.13%. Comparing base (8f5d0f4) to head (c68e053).
Report is 7 commits behind head on dev.

Files Patch % Lines
...ollers/format-painter/format-painter.controller.ts 89.74% 8 Missing ⚠️
.../services/format-painter/format-painter.service.ts 86.11% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2505      +/-   ##
==========================================
+ Coverage   27.12%   27.13%   +0.01%     
==========================================
  Files        1653     1653              
  Lines       83315    83357      +42     
  Branches    17258    17264       +6     
==========================================
+ Hits        22598    22619      +21     
- Misses      60717    60738      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@yuhongz yuhongz merged commit 1580ee0 into dev Jun 13, 2024
11 checks passed
@yuhongz yuhongz deleted the yuhongz/refactor-formatpainter branch June 13, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants