feat: formulas implemented #2496
Conversation
| expect(result.getValue()).toBe(0); | ||
| }); | ||
|
|
||
| it('Value is array', () => { |
There was a problem hiding this comment.
Do not remove any existing test cases
| expect(result.getValue()).toBe(0); | ||
| }); | ||
|
|
||
| it('Value is array', () => { |
| import { ErrorType } from '../../../../basics/error-type'; | ||
| import { ErrorValueObject } from '../../../../engine/value-object/base-value-object'; | ||
|
|
||
| describe('Test acoth function', () => { |
There was a problem hiding this comment.
Need to support tests for array formulas
| import { ErrorType } from '../../../../basics/error-type'; | ||
| import { ErrorValueObject } from '../../../../engine/value-object/base-value-object'; | ||
|
|
||
| describe('Test asin function', () => { |
There was a problem hiding this comment.
Need to support tests for array formulas
|
Please make sure all CI passes |
| } | ||
|
|
||
| // Assuming variant1 and variant2 can be arrays of different lengths | ||
| let array1 = Array.isArray(variant1) ? variant1 : [variant1]; |
There was a problem hiding this comment.
The row length and column lenth of two 2D arrays may be different. Both row and column need to be expanded to be consistent. You cannot just process the row length. Please refer to the usage of expandArrayValueObject in the source code for expansion.
| import { ErrorType } from '../../../../basics/error-type'; | ||
| import { ErrorValueObject } from '../../../../engine/value-object/base-value-object'; | ||
|
|
||
| describe('Test atan2 function', () => { |
There was a problem hiding this comment.
There is no test for array parameters of different sizes. Multiple combinations are required, such as testing numbers and arrays, strings and arrays, numbers and strings, arrays and arrays, etc.
| number1: { name: 'number1', detail: 'first' }, | ||
| number2: { name: 'number2', detail: 'second' }, | ||
| number1: { name: 'number1', detail: 'The real number for which you want to calculate the hyperbolic cosine.' }, | ||
| number2: { name: 'number2', detail: 'Optional. A second real number.' }, |
| number1: { name: 'number1', detail: 'first' }, | ||
| number2: { name: 'number2', detail: 'second' }, | ||
| number1: { name: 'number1', detail: 'The angle in radians for which you want to calculate the cotangent.' }, | ||
| number2: { name: 'number2', detail: 'Optional. A second angle.' }, |
| @@ -144,6 +144,7 @@ export const FUNCTION_LIST_MATH: IFunctionInfo[] = [ | |||
| }, | |||
| ], | |||
There was a problem hiding this comment.
need handle functionParameter in function-list, you can test in UI
close #xxx
Pull Request Checklist