feat: error handling and array expansion #2474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dushusir
reviewed
Jun 11, 2024
| } | ||
|
|
||
| if (!Number.isFinite(currentValue) || Number(currentValue) < -1 || Number(currentValue) > 1) { | ||
| return ErrorValueObject.create(ErrorType.VALUE); |
There was a problem hiding this comment.
should reports #NUM!
Please check other functions for similar situations. We hope to be as consistent as possible with Excel's errors.
View Deployment
|
Dushusir
requested changes
Jun 11, 2024
| return ErrorValueObject.create(ErrorType.VALUE); | ||
| } | ||
|
|
||
| const result = Math.atan2(Number(currentValue1), Number(currentValue2)); |
There was a problem hiding this comment.
|
Please check the PR title and test errors, and make sure it passes all CI (except Univer Merge Assistant, which is manually triggered by our QA) |
Dushusir
reviewed
Jun 11, 2024
| } | ||
|
|
||
| if (typeof value !== 'number' || value < -1 || value > 1) { | ||
| return ErrorValueObject.create(ErrorType.VALUE); |
|
Please refer to the second step to complete the internationalization content, refer to https://univer.ai/guides/sheet/customization/formula#how-to-implement-the-formula, just like adding When you enter the formula, you can trigger the auto-completion, which means that the internationalization content has been added successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2425
Pull Request Checklist