Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use @univerjs/ui useObservable #2456

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: use @univerjs/ui useObservable #2456

merged 1 commit into from
Jun 18, 2024
+6 −4

Conversation

semmywong
Copy link
Contributor

close #2349

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 7, 2024
@jikkai jikkai requested a review from wzhudev June 7, 2024 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

wzhudev
wzhudev approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@wzhudev wzhudev merged commit 8d6037d into dream-num:dev Jun 18, 2024
8 of 9 checks passed
@semmywong semmywong deleted the fix/useObservable branch June 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees
No one assigned
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] @wendellhu/redi not export useObservable
2 participants
@semmywong @wzhudev