Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link): skip error on ref-range mutation #2446

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 7, 2024

When both position and payload of hyperlink refer to same area, when delete this area, update-link-mutation will return false cause the link is deleted. This case should be ignored.

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (cfdc48f) to head (7d3659c).

Files Patch % Lines
...s/sheets-hyper-link/src/models/hyper-link.model.ts 0.00% 7 Missing ⚠️
...c/commands/mutations/update-hyper-link.mutation.ts 0.00% 4 Missing ⚠️
...hyper-link/src/controllers/ref-range.controller.ts 0.00% 3 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2446      +/-   ##
==========================================
- Coverage   27.12%   27.12%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       83302    83307       +5     
  Branches    17255    17257       +2     
==========================================
- Hits        22595    22594       -1     
- Misses      60707    60713       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 7, 2024

View Deployment

#9461645654

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@weird94 weird94 merged commit 56c6e12 into dev Jun 11, 2024
9 checks passed
@weird94 weird94 deleted the fix/hyper-link-ref-range branch June 11, 2024 07:40
lumixraku pushed a commit that referenced this pull request Jun 17, 2024
* feat: skip error on ref-range mutation

* feat: i18n

* feat: update

* fix: intersets

* feat: style

* feat: remove skip error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants