Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): init basic mobile features #2443

Merged
merged 27 commits into from
Jun 25, 2024
Merged

feat(mobile): init basic mobile features #2443

merged 27 commits into from
Jun 25, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 7, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev
Copy link
Member Author

wzhudev commented Jun 7, 2024

截屏2024-06-13 17 38 39

Copy link

github-actions bot commented Jun 7, 2024

View Deployment

#9658542021

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 1.36286% with 579 lines in your changes missing coverage. Please review.

Project coverage is 26.94%. Comparing base (cf60994) to head (d56ef61).
Report is 2 commits behind head on dev.

Files Patch % Lines
...validation/src/controllers/dv-render.controller.ts 0.00% 86 Missing ⚠️
...ges/ui/src/controllers/ui/ui-mobile.controller.tsx 0.00% 57 Missing ⚠️
...s-ui/src/views/mobile/sheet-bar/MobileSheetBar.tsx 0.00% 48 Missing ⚠️
...c/controllers/mobile/mobile-sheet-ui.controller.ts 0.00% 47 Missing ⚠️
packages/ui/src/views/MobileApp.tsx 0.00% 44 Missing ⚠️
packages/sheets-ui/src/mobile-sheets-ui-plugin.ts 0.00% 35 Missing ⚠️
.../src/components/menu/mobile/MobileMenu.stories.tsx 0.00% 32 Missing ⚠️
...iews/components/context-menu/MobileContextMenu.tsx 0.00% 28 Missing ⚠️
...ers/mobile/mobile-contextmenu.render-controller.ts 0.00% 24 Missing ⚠️
...ets-conditional-formatting-ui/src/mobile-plugin.ts 0.00% 22 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2443      +/-   ##
==========================================
- Coverage   27.11%   26.94%   -0.17%     
==========================================
  Files        1675     1691      +16     
  Lines       84710    85239     +529     
  Branches    17656    17729      +73     
==========================================
+ Hits        22968    22970       +2     
- Misses      61742    62269     +527     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dream-num dream-num deleted a comment from univer-bot bot Jun 13, 2024
@wzhudev wzhudev marked this pull request as ready for review June 25, 2024 06:50
@wzhudev wzhudev changed the title feat: init basic mobile features feat(mobile): init basic mobile features Jun 25, 2024
@wzhudev wzhudev requested a review from hexf00 as a code owner June 25, 2024 07:09
@wzhudev wzhudev merged commit 3583fe5 into dev Jun 25, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/mobile-poc branch June 25, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant