Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): sort feature #2435

Open
wants to merge 75 commits into
base: dev
Choose a base branch
from
Open

feat(sheet): sort feature #2435

wants to merge 75 commits into from

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 6, 2024

close https://github.com/dream-num/univer-pro/issues/660

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 17.98561% with 684 lines in your changes missing coverage. Please review.

Project coverage is 27.01%. Comparing base (b1dc036) to head (22d23d5).
Report is 12 commits behind head on dev.

Files Patch % Lines
...ts-sort-ui/src/services/sheets-sort-ui.service.tsx 0.00% 128 Missing ⚠️
...kages/sheets-sort-ui/src/views/CustomSortPanel.tsx 0.00% 86 Missing ⚠️
...es/sheets-sort/src/services/sheets-sort.service.ts 16.17% 57 Missing ⚠️
...rt-ui/src/controllers/sheets-sort-ui.controller.ts 0.00% 51 Missing ⚠️
packages/sheets/src/basics/utils.ts 0.00% 49 Missing ⚠️
packages/sheets/src/services/ref-range/util.ts 4.54% 42 Missing ⚠️
...sheets-sort-ui/src/commands/sheets-sort.command.ts 0.00% 40 Missing ⚠️
...sheets-sort-ui/src/controllers/sheets-sort.menu.ts 0.00% 31 Missing ⚠️
...filter/src/controllers/sheets-filter.controller.ts 6.45% 29 Missing ⚠️
packages/sheets-sort/src/controllers/utils.ts 61.01% 23 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2435      +/-   ##
==========================================
- Coverage   27.19%   27.01%   -0.18%     
==========================================
  Files        1653     1675      +22     
  Lines       83583    84721    +1138     
  Branches    17391    17613     +222     
==========================================
+ Hits        22729    22888     +159     
- Misses      60854    61833     +979     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Some code quality issue needs to be addressed.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhongz yuhongz requested a review from Dushusir as a code owner June 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants