Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimization of doc image #2432

Open
wants to merge 44 commits into
base: dev
Choose a base branch
from
Open

feat: optimization of doc image #2432

wants to merge 44 commits into from

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jun 5, 2024

close https://github.com/dream-num/univer-pro/issues/1101

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs force-pushed the feat/optimization-doc-image branch from f976926 to 444e1c2 Compare June 5, 2024 13:07
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 2.10938% with 1253 lines in your changes missing coverage. Please review.

Project coverage is 26.76%. Comparing base (f49fed1) to head (b99321b).
Report is 9 commits behind head on dev.

Current head b99321b differs from pull request most recent head 6861647

Please upload reports for the commit 6861647 to get more accurate results.

Files Patch % Lines
...rc/commands/commands/update-doc-drawing.command.ts 0.00% 268 Missing ⚠️
...llers/doc-drawing-transformer-update.controller.ts 0.00% 247 Missing ⚠️
...i/src/views/doc-image-panel/DocDrawingPosition.tsx 0.00% 152 Missing ⚠️
...i/src/views/doc-image-panel/DocDrawingTextWrap.tsx 0.00% 119 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 109 Missing ⚠️
...controllers/doc-drawing-notification.controller.ts 0.00% 96 Missing ⚠️
...i/src/controllers/doc-drawing-update.controller.ts 0.00% 53 Missing ⚠️
...rc/commands/commands/remove-doc-drawing.command.ts 0.00% 39 Missing ⚠️
...rc/commands/commands/insert-doc-drawing.command.ts 0.00% 35 Missing ⚠️
...-ui/src/commands/commands/move-drawings.command.ts 0.00% 26 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2432      +/-   ##
==========================================
- Coverage   27.06%   26.76%   -0.30%     
==========================================
  Files        1677     1681       +4     
  Lines       84765    85938    +1173     
  Branches    17626    17944     +318     
==========================================
+ Hits        22938    23001      +63     
- Misses      61827    62937    +1110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs force-pushed the feat/optimization-doc-image branch 5 times, most recently from 94940cc to 03ac12a Compare June 7, 2024 15:05
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 2 times, most recently from 1333ffe to efc11dc Compare June 19, 2024 03:46
@Jocs Jocs marked this pull request as ready for review June 19, 2024 09:05
@Jocs Jocs added the qa:untested This PR is ready to be tested label Jun 19, 2024
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 2 times, most recently from c34d8b3 to f440374 Compare June 21, 2024 11:59
@Jocs Jocs force-pushed the feat/optimization-doc-image branch from f440374 to 49471f6 Compare June 22, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant