Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message node env #2417

Merged
merged 4 commits into from
Jun 4, 2024
Merged

fix: message node env #2417

merged 4 commits into from
Jun 4, 2024

Conversation

VicKun4937
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@VicKun4937 VicKun4937 changed the title Fix message node env fix: message node env Jun 4, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (8657cc4) to head (2e1e6e6).

Files Patch % Lines
packages/design/src/components/message/Message.tsx 60.00% 2 Missing ⚠️
...ui/src/services/message/desktop-message.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2417      +/-   ##
==========================================
+ Coverage   27.09%   27.11%   +0.01%     
==========================================
  Files        1646     1646              
  Lines       83102    83105       +3     
  Branches    17219    17221       +2     
==========================================
+ Hits        22520    22531      +11     
+ Misses      60582    60574       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

View Deployment

#9366097873

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@jikkai jikkai merged commit 3dd2d6a into dev Jun 4, 2024
9 checks passed
@jikkai jikkai deleted the fix-message-node-env branch June 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants