Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: syncing mutation should be registered explicitly #2401

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 3, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from DR-Univer as a code owner June 3, 2024 09:55
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 27.13%. Comparing base (f339ebd) to head (d299ec4).
Report is 1 commits behind head on dev.

Files Patch % Lines
...eets/src/controllers/basic-worksheet.controller.ts 0.00% 6 Missing ⚠️
...ngine-formula/src/controller/formula.controller.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2401      +/-   ##
==========================================
- Coverage   27.13%   27.13%   -0.01%     
==========================================
  Files        1646     1646              
  Lines       83042    83047       +5     
  Branches    17203    17203              
==========================================
  Hits        22534    22534              
- Misses      60508    60513       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit c5ae960 into dev Jun 3, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/explicitly-sync branch June 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants