Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): support @DependentOn decorator #2397

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 3, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 53.50877% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 27.12%. Comparing base (0a9a980) to head (23d0307).

Files Patch % Lines
...ackages/core/src/services/plugin/plugin.service.ts 64.51% 33 Missing ⚠️
packages/thread-comment-ui/src/plugin.ts 0.00% 5 Missing ⚠️
packages/sheets-thread-comment/src/plugin.ts 0.00% 4 Missing ⚠️
packages/sheets-hyper-link-ui/src/plugin.ts 0.00% 3 Missing ⚠️
packages/core/src/services/plugin/plugin.ts 50.00% 1 Missing ⚠️
packages/data-validation/src/plugin.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/render-engine.ts 0.00% 1 Missing ⚠️
packages/sheets-drawing-ui/src/plugin.ts 0.00% 1 Missing ⚠️
packages/sheets-drawing/src/plugin.ts 0.00% 1 Missing ⚠️
packages/sheets-find-replace/src/plugin.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2397      +/-   ##
==========================================
- Coverage   27.13%   27.12%   -0.01%     
==========================================
  Files        1647     1646       -1     
  Lines       83019    83042      +23     
  Branches    17201    17203       +2     
==========================================
- Hits        22527    22525       -2     
- Misses      60492    60517      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev requested a review from hexf00 as a code owner June 3, 2024 08:24
@wzhudev wzhudev merged commit f339ebd into dev Jun 3, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/plugin-dependent-on branch June 3, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants