Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix permissions wrong reference render-engine in sheets package #2396

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Jun 3, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (f339ebd) to head (c626aca).
Report is 9 commits behind head on dev.

Files Patch % Lines
...ers/permission/sheet-permission-init.controller.ts 0.00% 1 Missing ⚠️
...ermission-interceptor-formula-render.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2396      +/-   ##
==========================================
- Coverage   27.13%   27.09%   -0.04%     
==========================================
  Files        1646     1646              
  Lines       83042    83100      +58     
  Branches    17203    17217      +14     
==========================================
- Hits        22534    22520      -14     
- Misses      60508    60580      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky force-pushed the fix-sheets-permission-import branch from 6b482b5 to 2a4a97e Compare June 3, 2024 09:40
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 4, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 4, 2024
@ybzky ybzky merged commit 10387e4 into dev Jun 4, 2024
9 checks passed
@ybzky ybzky deleted the fix-sheets-permission-import branch June 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants