Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): enhance component container #2395

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 3, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested review from jikkai and Jocs as code owners June 3, 2024 04:03
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 27.08%. Comparing base (dc8b0ac) to head (d6de2e6).

Files Patch % Lines
...ges/ui/src/views/components/ComponentContainer.tsx 0.00% 12 Missing ⚠️
...ui/src/services/message/desktop-message.service.ts 0.00% 4 Missing ⚠️
packages/design/src/components/message/Message.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2395      +/-   ##
==========================================
- Coverage   27.09%   27.08%   -0.01%     
==========================================
  Files        1647     1647              
  Lines       82997    83012      +15     
  Branches    17198    17200       +2     
==========================================
  Hits        22485    22485              
- Misses      60512    60527      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 54460f9 into dev Jun 3, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/component-manager branch June 3, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant