Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): dispose cycle #2393

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jun 1, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer requested a review from lumixraku as a code owner June 1, 2024 13:31
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.09%. Comparing base (e971e28) to head (a466338).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2393      +/-   ##
==========================================
- Coverage   27.10%   27.09%   -0.02%     
==========================================
  Files        1645     1645              
  Lines       82972    82970       -2     
  Branches    17195    17195              
==========================================
- Hits        22489    22479      -10     
- Misses      60483    60491       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit bfe75db into dev Jun 1, 2024
13 checks passed
@DR-Univer DR-Univer deleted the fix-render-secene-dispose-cycle branch June 1, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant