Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing-ui): fix incomplete display of drawing panel styles #2387

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jun 1, 2024

close https://github.com/dream-num/univer-pro/issues/1033

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.10%. Comparing base (3345064) to head (841c522).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2387   +/-   ##
=======================================
  Coverage   27.10%   27.10%           
=======================================
  Files        1645     1645           
  Lines       82972    82972           
  Branches    17195    17195           
=======================================
+ Hits        22488    22489    +1     
+ Misses      60484    60483    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 1, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 9831db9 into dev Jun 2, 2024
11 checks passed
@wzhudev wzhudev deleted the style/drawing-pannel branch June 2, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants