Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(drawing): fix dependencies #2386

Merged
merged 3 commits into from
Jun 2, 2024
Merged

refactor(drawing): fix dependencies #2386

merged 3 commits into from
Jun 2, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 1, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev changed the title WIP refactor(drawing): fix dependencies Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 3.57895% with 458 lines in your changes are missing coverage. Please review.

Project coverage is 27.07%. Comparing base (3345064) to head (fa32072).
Report is 3 commits behind head on dev.

Files Patch % Lines
...awing/src/services/drawing-manager-impl.service.ts 0.00% 379 Missing ⚠️
...ages/drawing/src/services/image-io-impl.service.ts 0.00% 43 Missing ⚠️
...es/drawing/src/services/drawing-manager.service.ts 0.00% 18 Missing ⚠️
packages/drawing/src/services/image-io.service.ts 0.00% 11 Missing ⚠️
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 4 Missing ⚠️
packages/drawing/src/plugin.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2386      +/-   ##
==========================================
- Coverage   27.10%   27.07%   -0.04%     
==========================================
  Files        1645     1646       +1     
  Lines       82972    82981       +9     
  Branches    17195    17197       +2     
==========================================
- Hits        22488    22465      -23     
- Misses      60484    60516      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 2, 2024

View Deployment

#9336325099

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@wzhudev wzhudev marked this pull request as ready for review June 2, 2024 06:47
@wzhudev wzhudev merged commit 2689c1d into dev Jun 2, 2024
13 checks passed
@wzhudev wzhudev deleted the refactor/drawing-modules branch June 2, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant