Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link-ui): email link jump error #2378

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 1, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 1, 2024
@weird94 weird94 requested a review from wzhudev June 1, 2024 03:17
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 27.20%. Comparing base (1f95047) to head (07bd92d).

Files Patch % Lines
packages/sheets-hyper-link-ui/src/common/util.ts 0.00% 7 Missing ⚠️
...r-link-ui/src/controllers/copy-paste.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2378      +/-   ##
==========================================
- Coverage   27.21%   27.20%   -0.01%     
==========================================
  Files        1640     1640              
  Lines       82553    82559       +6     
  Branches    17085    17085              
==========================================
  Hits        22463    22463              
- Misses      60090    60096       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jun 1, 2024
@weird94 weird94 merged commit 950be43 into dev Jun 1, 2024
13 checks passed
@weird94 weird94 deleted the fix/email-hyper-link branch June 1, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants