Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing): doc drawing same to sheet drawing #2372

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented May 31, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 27.29%. Comparing base (09518aa) to head (65bbba3).
Report is 1 commits behind head on dev.

Files Patch % Lines
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 8 Missing ⚠️
...i/src/controllers/doc-drawing-update.controller.ts 0.00% 6 Missing ⚠️
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2372      +/-   ##
==========================================
- Coverage   27.30%   27.29%   -0.02%     
==========================================
  Files        1636     1636              
  Lines       82285    82292       +7     
  Branches    17045    17046       +1     
==========================================
- Hits        22471    22460      -11     
- Misses      59814    59832      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit e3f6654 into dev May 31, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-doc-drawing branch May 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant