Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): fix data-validation type number and whole title display error #2370

Merged
merged 1 commit into from
May 31, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented May 31, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 31, 2024
@weird94 weird94 changed the title fix: dv 18n fix(sheets-data-validation): data-validation type number and whole title display error May 31, 2024
@weird94 weird94 changed the title fix(sheets-data-validation): data-validation type number and whole title display error fix(sheets-data-validation): fix data-validation type number and whole title display error May 31, 2024
@weird94 weird94 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.25%. Comparing base (a98e8ab) to head (93b11dd).

Files Patch % Lines
...ata-validation/src/validators/decimal-validator.ts 0.00% 1 Missing ⚠️
...-data-validation/src/validators/whole-validator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2370      +/-   ##
==========================================
- Coverage   29.26%   29.25%   -0.02%     
==========================================
  Files        1516     1516              
  Lines       76736    76736              
  Branches    15942    15942              
==========================================
- Hits        22457    22447      -10     
- Misses      54279    54289      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit da8b06b into dev May 31, 2024
15 checks passed
@weird94 weird94 deleted the fix/dv-18n-2 branch May 31, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants