Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not escape when copy content #2354

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix: not escape when copy content #2354

merged 3 commits into from
Jun 5, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented May 30, 2024

close #1995

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner May 30, 2024 03:27
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (ed39371) to head (579a780).
Report is 3 commits behind head on dev.

Files Patch % Lines
...ui/src/services/clipboard/html-to-usm/converter.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2354      +/-   ##
==========================================
+ Coverage   27.09%   27.11%   +0.01%     
==========================================
  Files        1647     1647              
  Lines       83115    83120       +5     
  Branches    17223    17225       +2     
==========================================
+ Hits        22523    22536      +13     
+ Misses      60592    60584       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 1, 2024
@zhaolixin7
Copy link

@univer-bot
Copy link

univer-bot bot commented Jun 1, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@ybzky pasting into document not fixed
2024_6_1 15_21_31 commands.json
2024_6_1 15_21_31 video.webm

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 5, 2024
@univer-bot univer-bot bot removed the qa:rejected label Jun 5, 2024
@ybzky ybzky merged commit c10e4d9 into dev Jun 5, 2024
13 checks passed
@ybzky ybzky deleted the fix-copy-not-escape branch June 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Copying data with special symbols to external txt, excel exception
3 participants