refactor(sheet): refactor the loading current sheet #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
reviewed
Oct 6, 2023
packages/ui-plugin-sheets/src/services/cell-editor/cell-editor-desktop.service.ts
Show resolved
Hide resolved
| * should start renderLoop Immediately | ||
| * default is true | ||
| */ | ||
| shouldRenderLoopImmediately?: boolean; |
| return null; | ||
| } | ||
|
|
||
| if (this._canvasEle && this._canvasEle.ownerDocument && this._canvasEle.ownerDocument.defaultView) { |
| @@ -103,6 +89,26 @@ export class Documents extends DocComponent { | |||
| return new Documents(oKey, documentSkeleton, config); | |||
| } | |||
|
|
|||
| setConfig(config?: IDocumentsConfig) { | |||
| if (config?.pageMarginLeft === undefined) { | |||
There was a problem hiding this comment.
这里用对象展开操作符合并默认值就行，不用写这么多 if else
There was a problem hiding this comment.
之前直接搬过来的，改造的时候 我再处理下
| @@ -289,3 +289,5 @@ export enum RENDER_CLASS_TYPE { | |||
| LAYER = 'Layer', | |||
| GROUP = 'Group', | |||
| } | |||
|
|
|||
| export const DOCS_EDITOR_UNIT_ID_KEY = '__defaultDocumentEditorSpecialUnitId_20231006__'; | |||
There was a problem hiding this comment.
咱们今天得出的结论哈哈，保持这个editor的绝对唯一性 哈哈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.