Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): insert row supports cell value #2346

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 29, 2024

close #2243

How to test?
uniscript (uniscript editor or browser console)

const activeWorkbook = univerAPI.getActiveWorkbook();
const activeSheet = activeWorkbook.getActiveSheet();
univerAPI.executeCommand('sheet.command.insert-row', {
    unitId: activeWorkbook?.getId(),
    subUnitId: activeSheet.getSheetId(),
    direction: 2,
    range: { startRow: 6, endRow: 6, startColumn: 0, endColumn: 0 },
    cellValue:{
        6:{
            0: {
                v: 'Hello,Univer',
                s:{
                    bg:{
                        rgb: '#FF0000',
                    }
                }
            }
        }
    }   
})

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.24%. Comparing base (91f3b7c) to head (2899735).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2346      +/-   ##
==========================================
+ Coverage   29.22%   29.24%   +0.01%     
==========================================
  Files        1515     1515              
  Lines       76684    76698      +14     
  Branches    15921    15925       +4     
==========================================
+ Hits        22414    22428      +14     
  Misses      54270    54270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review May 29, 2024 09:06
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 29, 2024
@Dushusir Dushusir requested review from yuhongz and ybzky and removed request for wzhudev and DR-Univer May 29, 2024 09:06
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 29, 2024
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir merged commit c87246c into dev May 29, 2024
10 checks passed
@Dushusir Dushusir deleted the dushusir/insert-row branch May 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] InsertRowCommand not work, cellValue not showing
4 participants