Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multiple dialogs being opened at the same time #2341

Merged
merged 1 commit into from
May 28, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented May 28, 2024

close #777

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from jikkai and Jocs as code owners May 28, 2024 13:11
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 28, 2024
@jikkai jikkai removed the qa:untested This PR is ready to be tested label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.24%. Comparing base (09fd989) to head (3e15b93).
Report is 2 commits behind head on dev.

Files Patch % Lines
...s/ui/src/services/dialog/desktop-dialog.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2341      +/-   ##
==========================================
- Coverage   29.24%   29.24%   -0.01%     
==========================================
  Files        1515     1515              
  Lines       76673    76677       +4     
  Branches    15916    15918       +2     
==========================================
  Hits        22424    22424              
- Misses      54249    54253       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky merged commit ce5d10c into dev May 28, 2024
14 checks passed
@ybzky ybzky deleted the fix-dialog-visible branch May 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants