Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear format failed when not change selections #2338

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 28, 2024

close #1231

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review May 28, 2024 12:08
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.24%. Comparing base (09fd989) to head (344b8b5).
Report is 3 commits behind head on dev.

Files Patch % Lines
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2338      +/-   ##
==========================================
- Coverage   29.24%   29.24%   -0.01%     
==========================================
  Files        1515     1515              
  Lines       76673    76677       +4     
  Branches    15916    15917       +1     
==========================================
  Hits        22424    22424              
- Misses      54249    54253       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 29, 2024
@Jocs Jocs merged commit 07a4e0f into dev May 29, 2024
13 checks passed
@Jocs Jocs deleted the fix/clear-format branch May 29, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Right-click menu clear format fails
3 participants