Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change message and notification API #2332

Merged
merged 3 commits into from
May 28, 2024
Merged

feat: change message and notification API #2332

merged 3 commits into from
May 28, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 28, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Breaking changes:

  • IMessageMethodOptions is renamed to IMessageOptions

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 30.05%. Comparing base (8cd421b) to head (ffbfb0d).

Files Patch % Lines
packages/design/src/components/message/Message.tsx 55.55% 4 Missing ⚠️
...es/ui/src/components/notification/Notification.tsx 0.00% 1 Missing ⚠️
...rvices/message/__testing__/mock-message.service.ts 0.00% 1 Missing ⚠️
...ui/src/services/message/desktop-message.service.ts 0.00% 1 Missing ⚠️
...ackages/ui/src/services/message/message.service.ts 0.00% 1 Missing ⚠️
.../src/services/notification/notification.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2332   +/-   ##
=======================================
  Coverage   30.05%   30.05%           
=======================================
  Files        1421     1421           
  Lines       73107    73107           
  Branches    15317    15317           
=======================================
  Hits        21975    21975           
  Misses      51132    51132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 5cc6881 into dev May 28, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/message-api branch May 28, 2024 06:22
Copy link

View Deployment

#9264490596

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant