Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sheets-hyper-link): add hyper link for sheet #2330

Merged
merged 180 commits into from
May 31, 2024
Merged

feat(sheets-hyper-link): add hyper link for sheet #2330

merged 180 commits into from
May 31, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented May 27, 2024 •
edited
Loading

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

weird94 and others added 30 commits May 23, 2024 15:50
@weird94
feat: init
16eca99
@weird94
feat: temp
0977622
@weird94
feat: sheets-hyper-link
82f5a6e
@weird94
feat: hyper-link-ui
dd5ee0d
@weird94
Merge branch 'dev' into feat/hyper-link
5e5a66a
@DR-Univer
refactor(image): delete image render service
53c582c
@DR-Univer
feat(image): add plugin
c40116a
@DR-Univer
feat(image): load
877d648
@DR-Univer
feat(sheet): source work flow
2f68381
@DR-Univer
feat(image): merge command
a089251
@DR-Univer
feat(image): insert image to sheet
9fc244f
@DR-Univer
feat(image): update transformer
68a47b7
@DR-Univer
feat(image): transformer fix ratio
ae10745
@DR-Univer
fix(render): transformer rotate
ad9f4d1
@DR-Univer
feat(image): transformer and command
cd5e40f
@DR-Univer
feat(sheet): add panel for image
89c9cfe
@DR-Univer
feat(image): cropper
8ed6582
@DR-Univer
feat(image): copper event
34bbdc9
@DR-Univer
feat(image): cropper and move
2b0bf20
@DR-Univer
refactor(image): update drawing plugin
516f699
@DR-Univer
fix(sheet): update lock
5209476
@DR-Univer
fix(sheet): type error
b916a20
@DR-Univer
fix(image): type error
56e13f3
@DR-Univer
fix(sheet): type error
a62b456
@DR-Univer
feat(image): group and arrange
5836b6e
@DR-Univer
refactor(sheet): drawing service
e436338
@wzhudev @DR-Univer
feat: some commands don't have to register in worker
ebab335
@DR-Univer
refactor(drawing): ot json finish
91bb238
@DR-Univer
refactor(drawing): change image to drawing ui
b813319
@DR-Univer
fix(drawing): rebase
dd105d6
@weird94
Copy link
Contributor Author

weird94 commented May 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

pkg

@weird94
Copy link
Contributor Author

weird94 commented May 31, 2024

#2330 (comment)

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 31, 2024
wzhudev
wzhudev approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 09518aa into dev May 31, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/hyper-link branch May 31, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees

@weird94 weird94

@oumomomo oumomomo

Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@weird94 @wzhudev @oumomomo @DR-Univer @ybzky