Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): add info type for Message component, use barColor in ProgressBar #2277

Merged
merged 3 commits into from
May 22, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 20, 2024

  • Use barColor in progress bar props
  • Add info type for Message component

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 30.28%. Comparing base (7443feb) to head (6be9326).

Files Patch % Lines
packages/design/src/components/message/Message.tsx 33.33% 2 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 2 Missing ⚠️
...ges/ui/src/components/progress-bar/ProgressBar.tsx 0.00% 2 Missing ⚠️
.../design/src/components/message/Message.stories.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2277      +/-   ##
==========================================
- Coverage   30.28%   30.28%   -0.01%     
==========================================
  Files        1413     1413              
  Lines       72265    72270       +5     
  Branches    15149    15149              
==========================================
+ Hits        21885    21886       +1     
- Misses      50380    50384       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review May 20, 2024 10:02
@Dushusir Dushusir changed the title fix(sheet): progress for import fix(sheet): add info type for Message component, use barColor in ProgressBar May 20, 2024
@Dushusir Dushusir force-pushed the dushusir/progress-for-import branch from 8258180 to 6be9326 Compare May 21, 2024 11:53
@jikkai jikkai merged commit 7b411b3 into dev May 22, 2024
9 checks passed
@jikkai jikkai deleted the dushusir/progress-for-import branch May 22, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants