Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): focusing error #2264

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(editor): focusing error #2264

merged 1 commit into from
May 17, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented May 17, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.86%. Comparing base (5e02b6e) to head (43cc9a7).
Report is 1 commits behind head on dev.

Files Patch % Lines
...cs-ui/src/controllers/text-selection.controller.ts 0.00% 1 Missing ⚠️
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2264      +/-   ##
==========================================
+ Coverage   30.83%   30.86%   +0.02%     
==========================================
  Files        1378     1379       +1     
  Lines       70765    70891     +126     
  Branches    14883    14905      +22     
==========================================
+ Hits        21822    21881      +59     
- Misses      48943    49010      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit 0831994 into dev May 17, 2024
13 checks passed
@DR-Univer DR-Univer deleted the fix-editor-focus-error branch May 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants