Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Singleton Pattern of Hyphen #2242

Merged
merged 3 commits into from
May 15, 2024
Merged

fix: use Singleton Pattern of Hyphen #2242

merged 3 commits into from
May 15, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 14, 2024

close #xxx, #yyy, #zzzz

@Jocs Jocs marked this pull request as ready for review May 14, 2024 13:23
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 30.85%. Comparing base (2739fba) to head (fe97920).

Files Patch % Lines
...nents/docs/layout/hyphenation/language-detector.ts 0.00% 5 Missing ⚠️
...r/src/components/docs/layout/hyphenation/hyphen.ts 20.00% 4 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2242      +/-   ##
==========================================
- Coverage   30.85%   30.85%   -0.01%     
==========================================
  Files        1358     1358              
  Lines       70616    70626      +10     
  Branches    14853    14855       +2     
==========================================
+ Hits        21791    21792       +1     
- Misses      48825    48834       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs merged commit ba853df into dev May 15, 2024
9 checks passed
@Jocs Jocs deleted the fix/unnecessary-hyphen branch May 15, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants