Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheets): bugfix for freeze & hover-manager-service & data-validation #2233

Merged
merged 12 commits into from
May 15, 2024
Merged

fix(sheets): bugfix for freeze & hover-manager-service & data-validation #2233

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8d228f5
fix: #684 univer-pro
weird94 May 11, 2024
7040ed1
feat: auto-height
weird94 May 13, 2024
5a506f7
Merge branch 'dev' into fix/daily-0511
weird94 May 13, 2024
d5d9645
feat: update
weird94 May 13, 2024
aaecc4d
fix: #2174
weird94 May 13, 2024
0b14ed2
feat: #2162 checkbox ticked and unticked value
weird94 May 13, 2024
ac6154c
fix: hover-manager-service
weird94 May 13, 2024
8f20f74
fix: checkbox validator
weird94 May 14, 2024
3735ca4
feat: lint
weird94 May 14, 2024
f3db37e
fix: error when delete worksheet
weird94 May 14, 2024
4b9ff12
feat: custom-render event handler
weird94 May 14, 2024
9a4d08c
Merge branch 'dev' into fix/daily-0511
weird94 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: error when delete worksheet
  • Loading branch information
@weird94
weird94 committed May 14, 2024
commit f3db37e199f1a1a127dd28c0be7ad941aee3c72d
2 changes: 1 addition & 1 deletion packages/sheets-data-validation/src/views/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function DataValidationListWithWorkbook(props: { workbook: Workbook }) {
const { workbook } = props;
const worksheet = useObservable(workbook.activeSheet$, undefined, true)!;
const unitId = workbook.getUnitId();
const subUnitId = worksheet.getSheetId();
const subUnitId = worksheet?.getSheetId();
const manager = dataValidationModel.ensureManager(unitId, subUnitId);

useEffect(() => {
Expand Down
Loading