Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): unhide hidden icon render incorrect when headers resize #2208

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(sheet): unhide hidden icon render incorrect when headers resize #2208

merged 1 commit into from
May 9, 2024

Conversation

siam-ese
Copy link
Contributor

@siam-ese siam-ese commented May 9, 2024

close #2169

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 9, 2024
wzhudev
wzhudev approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit a68bfb9 into dream-num:dev May 9, 2024
9 checks passed
@siam-ese siam-ese deleted the lzp/fix-expand-icon branch May 9, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Select a hidden row and then add a record, the hidden icon is displayed incorrectly
3 participants
@siam-ese @wzhudev @oumomomo