Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): text selection in multiple columns #2199

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(docs): text selection in multiple columns #2199

merged 2 commits into from
May 10, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 9, 2024

close #2175

@Jocs Jocs marked this pull request as ready for review May 9, 2024 03:12
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 30.65%. Comparing base (e00c660) to head (9c2b11f).

Files Patch % Lines
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2199      +/-   ##
==========================================
- Coverage   30.65%   30.65%   -0.01%     
==========================================
  Files        1272     1272              
  Lines       70148    70150       +2     
  Branches    14863    14863              
==========================================
- Hits        21504    21503       -1     
- Misses      48644    48647       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 9, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 9, 2024
@Jocs Jocs merged commit 5f9816e into dev May 10, 2024
9 checks passed
@Jocs Jocs deleted the fix/text-selection branch May 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] When the document is divided into columns, the content in the document cannot be selected.
3 participants
@Jocs @Gggpound @oumomomo