Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(formula): restore formula testing and add missing dependencies #2197

Merged
merged 1 commit into from
May 8, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 8, 2024

No description provided.

@Dushusir Dushusir requested review from wzhudev and jikkai May 8, 2024 13:12
@Dushusir Dushusir marked this pull request as ready for review May 8, 2024 13:12
@Dushusir Dushusir requested a review from DR-Univer as a code owner May 8, 2024 13:12
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.65%. Comparing base (476ffd3) to head (f232cac).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2197      +/-   ##
==========================================
- Coverage   30.91%   30.65%   -0.27%     
==========================================
  Files        1209     1272      +63     
  Lines       66690    70148    +3458     
  Branches    14094    14863     +769     
==========================================
+ Hits        20619    21503     +884     
- Misses      46071    48645    +2574     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit e00c660 into dev May 8, 2024
9 checks passed
@wzhudev wzhudev deleted the dushusir/formula-cal0508 branch May 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants