Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): memory leak #2166

Merged
merged 4 commits into from
May 7, 2024
Merged

fix(render): memory leak #2166

merged 4 commits into from
May 7, 2024

Conversation

DR-Univer
Copy link
Collaborator

No description provided.

@DR-Univer DR-Univer requested a review from lumixraku as a code owner May 7, 2024 03:44
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 173 lines in your changes are missing coverage. Please review.

Project coverage is 31.02%. Comparing base (73e8c02) to head (b5dc699).

Files Patch % Lines
packages/engine-render/src/engine.ts 0.00% 43 Missing ⚠️
packages/engine-render/src/scene.input-manager.ts 0.00% 19 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 17 Missing ⚠️
packages/engine-render/src/canvas.ts 0.00% 13 Missing ⚠️
packages/engine-render/src/thin-scene.ts 0.00% 12 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 10 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 9 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 7 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 6 Missing ⚠️
packages/engine-render/src/components/component.ts 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2166      +/-   ##
==========================================
- Coverage   31.08%   31.02%   -0.06%     
==========================================
  Files        1209     1209              
  Lines       66296    66408     +112     
  Branches    14026    14026              
==========================================
  Hits        20606    20606              
- Misses      45690    45802     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer requested a review from jikkai as a code owner May 7, 2024 06:22
@DR-Univer DR-Univer merged commit 9b078e2 into dev May 7, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-render-memory-leak branch May 7, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant