Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): data validation daily bugifx #2126

Merged
merged 13 commits into from
Apr 30, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 29, 2024

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 29, 2024
@weird94 weird94 requested a review from wzhudev April 29, 2024 14:02
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (49c1a70) to head (e48eb20).

Files Patch % Lines
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 18 Missing ⚠️
...validation/src/widgets/dropdown-multiple-widget.ts 0.00% 11 Missing ⚠️
...-data-validation/src/views/date-dropdown/index.tsx 0.00% 8 Missing ⚠️
...ion/src/views/formula-input/list-formula-input.tsx 0.00% 8 Missing ⚠️
...tion/src/controllers/dv-reject-input.controller.ts 0.00% 5 Missing ⚠️
...-render/src/components/sheets/extensions/custom.ts 0.00% 1 Missing ⚠️
...-render/src/components/sheets/extensions/marker.ts 0.00% 1 Missing ⚠️
...s-data-validation/src/validators/date-validator.ts 0.00% 1 Missing ⚠️
...ata-validation/src/validators/decimal-validator.ts 0.00% 1 Missing ⚠️
...validation/src/validators/text-length-validator.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2126      +/-   ##
==========================================
- Coverage   31.05%   31.04%   -0.02%     
==========================================
  Files        1209     1209              
  Lines       66211    66240      +29     
  Branches    14002    14014      +12     
==========================================
  Hits        20563    20563              
- Misses      45648    45677      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 changed the title fix(sheets-data-validation):data validation daily bugifx fix(sheets-data-validation): data validation daily bugifx Apr 30, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 30, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 30, 2024
@weird94 weird94 merged commit 3b45f89 into dev Apr 30, 2024
9 checks passed
@weird94 weird94 deleted the fix/data-validation-daily-0429 branch April 30, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants