Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make the source of univer-instance-type unique #2073

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Apr 25, 2024

  1. Unify the usage of UniforInstanceType
  2. Avoid misuse of @univerjs/protocol

Unless directly used at the network interface layer, types should be introduced from the @univerjs/core

pnpm build

and Don't use UNRECOGNIZED type , this is a generation error, may be fixed in the future, existing usage will be removed in other PRs

Copy link

github-actions bot commented Apr 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 176 lines in your changes are missing coverage. Please review.

Project coverage is 31.03%. Comparing base (e76fe4e) to head (f91ec89).

Files Patch % Lines
packages/slides/src/views/render/canvas-view.ts 0.00% 9 Missing ⚠️
...ervices/resource-loader/resource-loader.service.ts 0.00% 8 Missing ⚠️
...atting-ui/src/components/panel/rule-list/index.tsx 0.00% 6 Missing ⚠️
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 5 Missing ⚠️
.../sheets-ui/src/controllers/selection.controller.ts 0.00% 5 Missing ⚠️
...ges/core/src/services/instance/instance.service.ts 0.00% 4 Missing ⚠️
...ting-ui/src/controllers/cf.auto-fill.controller.ts 0.00% 4 Missing ⚠️
...-conditional-formatting-ui/src/menu/manage-rule.ts 0.00% 4 Missing ⚠️
...kages/sheets-ui/src/controllers/menu/sheet.menu.ts 0.00% 4 Missing ⚠️
...cs-ui/src/controllers/text-selection.controller.ts 0.00% 3 Missing ⚠️
... and 83 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2073      +/-   ##
==========================================
- Coverage   31.04%   31.03%   -0.01%     
==========================================
  Files        1208     1207       -1     
  Lines       66151    66145       -6     
  Branches    13995    13994       -1     
==========================================
- Hits        20537    20531       -6     
  Misses      45614    45614              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Apr 25, 2024

Merge this later after all other changes in 0.1.8. @hexf00 Please prepare to rebase on the latest dev.

@hexf00 hexf00 force-pushed the refactor/unique-univer-type-source branch 2 times, most recently from 485d853 to 1158b0a Compare April 25, 2024 13:10
@hexf00 hexf00 force-pushed the refactor/unique-univer-type-source branch from 1158b0a to b92e890 Compare April 25, 2024 13:24
@hexf00 hexf00 force-pushed the refactor/unique-univer-type-source branch from b92e890 to f91ec89 Compare April 26, 2024 02:51
@hexf00 hexf00 merged commit bee6d9b into dev Apr 26, 2024
8 of 9 checks passed
@hexf00 hexf00 deleted the refactor/unique-univer-type-source branch April 26, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants