Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix types and update codeowners #200

Merged
merged 4 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
packages/base-sheets/src/commands/commands/set-selections.command.ts @wzhudev
packages/ui-plugin-sheets/src/controller/shortcuts/selection.shortcut.ts @wzhudev
# core
packages/core @DR-Univer @wzhudev

# rendering
packages/base-render @DR-Univer @wzhudev

# business cores
packages/base-docs @wzhudev @DR-Univer @Jocs
packages/base-sheets @wzhudev @DR-Univer
packages/base-slides @wzhudev @DR-Univer @jikkai

# ui
packages/base-ui @jikkai @wzhudev
packages/ui-plugin-docs @jikkai @wzhudev
packages/ui-plugin-sheets @jikkai @wzhudev
packages/ui-plugin-slides @jikkai @wzhudev

# documents
docs/graphs.tldr @wzhudev

# sheet-plugins TBD
12 changes: 10 additions & 2 deletions packages/base-docs/src/View/Render/Views/DocsView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ export class DocsView extends BaseView {

scrollToCenter() {
const { docsLeft, docsTop } = this._documents.calculatePagePosition();
const pages = this._documentSkeleton.getSkeletonData().pages;
const pages = this._documentSkeleton.getSkeletonData()?.pages;

if (!pages) {
return;
}

for (let i = 0; i < pages.length; i++) {
const page = pages[i];
for (const k of page.skeDrawings.keys()) {
Expand Down Expand Up @@ -134,7 +139,10 @@ export class DocsView extends BaseView {
// }
// documents.calculatePagePosition();

const pages = documentSkeleton.getSkeletonData().pages;
const pages = documentSkeleton.getSkeletonData()?.pages;
if (!pages) {
throw new Error();
}

const { pageMarginLeft, pageMarginTop, docsLeft, docsTop } = documents.calculatePagePosition();

Expand Down
6 changes: 6 additions & 0 deletions packages/base-sheets/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export { NORMAL_SELECTION_PLUGIN_NAME, SelectionManagerService } from './service

// #region commands

export { type IInsertColMutationParams, type IInsertRowMutationParams } from './Basics/Interfaces/MutationInterface';
export {
AddWorksheetMergeAllCommand,
AddWorksheetMergeCommand,
Expand Down Expand Up @@ -100,12 +101,17 @@ export { SetRangeValuesMutation } from './commands/mutations/set-range-values.mu
export { SetTabColorMutation } from './commands/mutations/set-tab-color.mutation';
export { SetWorksheetActivateMutation } from './commands/mutations/set-worksheet-activate.mutation';
export {
type ISetWorksheetColWidthMutationParams,
SetWorksheetColWidthMutation,
SetWorksheetColWidthMutationFactory,
} from './commands/mutations/set-worksheet-col-width.mutation';
export { SetWorksheetHideMutation } from './commands/mutations/set-worksheet-hide.mutation';
export { SetWorksheetNameMutation } from './commands/mutations/set-worksheet-name.mutation';
export { SetWorksheetOrderMutation } from './commands/mutations/set-worksheet-order.mutation';
export {
type ISetWorksheetRowHeightMutationParams,
SetWorksheetRowHeightMutation,
} from './commands/mutations/set-worksheet-row-height.mutation';
export { SetSelectionsOperation } from './commands/operations/selection.operation';
export * from './Locale';

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading