Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add the Lower function #1970

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jackpk235
Copy link
Contributor

@jackpk235 jackpk235 commented Apr 18, 2024

  1. feat: add the formula algorithm
  2. feat: add the unit test
  3. feat: add the locale configs and descriptions

close #1951

@jackpk235 jackpk235 changed the title Feat/formula lower feat(formula): add the Lower function Apr 18, 2024
@wzhudev wzhudev requested review from Dushusir and removed request for DR-Univer April 18, 2024 07:08
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请避免出现 Merge branch 'feat/formula-lower' of 的情况,相关教程参考 https://www.cnblogs.com/Sinte-Beuve/p/9195018.html

Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

国际化没有加,类似这里

links: [
{
title: 'Instruction',
url: 'https://support.microsoft.com/en-us/office/lower-function-3f21df02-a80c-44b2-afaf-81358f9fdeb4',
},
],
functionParameter: {
number1: { name: 'number1', detail: 'first' },
number2: { name: 'number2', detail: 'second' },
text: { name: 'text', detail: 'Required. The text you want to convert to lowercase. LOWER does not change characters in text that are not letters.' },
Copy link
Member

@Dushusir Dushusir Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required. 不要加。可选还是必选需要在描述文档中配置 类似这里

functionName: FUNCTION_NAMES_TEXT.LOWER,

description: '将文本转换为小写',
abstract: '将文本转换为小写',
description: '将一个文本字符串中的所有大写字母转换为小写字母。',
abstract: '将一个文本字符串中的所有大写字母转换为小写字母',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的格式正确,但是我们推荐 abstract 保持简短,因为会在搜索列表中出现
image

@jackpk235 jackpk235 closed this Apr 19, 2024
@jackpk235 jackpk235 reopened this Apr 19, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 19, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 19, 2024
number1: { name: 'number1', detail: 'first' },
number2: { name: 'number2', detail: 'second' },
text: {
name: 'text',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text 中文和日语 需要翻译,多参考下文档和其他公式的写法
image
image

@jackpk235 jackpk235 reopened this Apr 22, 2024
Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir merged commit db3fa45 into dream-num:dev Apr 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Text Formula LOWER
4 participants