Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): range selector error #1897

Merged
merged 3 commits into from
Apr 13, 2024
Merged

fix(sheet): range selector error #1897

merged 3 commits into from
Apr 13, 2024

Conversation

DR-Univer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 29.52%. Comparing base (04abb1b) to head (c3ae659).

Files Patch % Lines
packages/ui/src/components/editor/TextEditor.tsx 0.00% 13 Missing ⚠️
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 8 Missing ⚠️
...ets-ui/src/views/defined-name/DefinedNameInput.tsx 0.00% 5 Missing ⚠️
packages/ui/src/services/layout/layout.service.ts 0.00% 3 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 1 Missing ⚠️
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1897      +/-   ##
==========================================
- Coverage   29.53%   29.52%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       63567    63576       +9     
  Branches    13432    13437       +5     
==========================================
  Hits        18773    18773              
- Misses      44794    44803       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 13, 2024
@DR-Univer DR-Univer merged commit a2c8cb6 into dev Apr 13, 2024
8 checks passed
@DR-Univer DR-Univer deleted the fix-range-selecor-error branch April 13, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants