Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): data-validation list support formula #1855

Closed
wants to merge 43 commits into from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 10, 2024

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 29.79%. Comparing base (2564456) to head (13e0886).

Files Patch % Lines
...s-data-validation/src/validators/list-validator.ts 0.00% 48 Missing ⚠️
...ion/src/views/formula-input/list-formula-input.tsx 0.00% 37 Missing ⚠️
...alidation/src/services/register-formula.service.ts 0.00% 7 Missing ⚠️
.../sheets-data-validation/src/views/detail/index.tsx 0.00% 6 Missing ⚠️
...dation/src/models/sheet-data-validation-manager.ts 0.00% 3 Missing ⚠️
...validation/src/widgets/dropdown-multiple-widget.ts 0.00% 3 Missing ⚠️
...lidation/src/controllers/dv-resource.controller.ts 0.00% 2 Missing ⚠️
...lidation/src/validators/list-multiple-validator.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #1855       +/-   ##
========================================
+ Coverage     0   29.79%   +29.79%     
========================================
  Files        0     1173     +1173     
  Lines        0    63998    +63998     
  Branches     0    13597    +13597     
========================================
+ Hits         0    19069    +19069     
- Misses       0    44929    +44929     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 requested a review from DR-Univer as a code owner April 15, 2024 05:30
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Apr 16, 2024
@weird94 weird94 closed this Apr 17, 2024
@weird94 weird94 deleted the feat/dv-list-formula branch May 31, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] a set of data-validation problem
2 participants