Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(conditional-formatting): subpackage ui #1739

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Mar 29, 2024

No description provided.

@Gggpound Gggpound changed the title Gggpound/feat cf subpackage 0329 chore(conditional-formatting): subpackage ui Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 31.61%. Comparing base (fd83cbf) to head (9a98230).

Files Patch % Lines
...ges/sheets-conditional-formatting-ui/src/plugin.ts 0.00% 21 Missing ⚠️
...ckages/sheets-conditional-formatting/src/plugin.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1739      +/-   ##
==========================================
- Coverage   31.77%   31.61%   -0.17%     
==========================================
  Files        1042     1043       +1     
  Lines       57867    57876       +9     
  Branches    12165    12165              
==========================================
- Hits        18388    18298      -90     
- Misses      39479    39578      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound force-pushed the gggpound/feat-cf-subpackage-0329 branch from 8343eb9 to 9a98230 Compare March 29, 2024 09:43
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gggpound Gggpound merged commit 82e5171 into dev Mar 29, 2024
8 checks passed
@Gggpound Gggpound deleted the gggpound/feat-cf-subpackage-0329 branch March 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants