Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix operation control of frozen rows and columns will disappear when zoomed out #1732

Closed
wants to merge 11 commits into from

Conversation

lumixraku
Copy link
Contributor

close #1718

fix operation control of frozen rows and columns will disappear when zoomed out #1718

wzhudev and others added 8 commits March 28, 2024 11:40
* fix: fix package.json conflicting

* fix: fix link

* fix: fix lock file
* feat(conditional-format): init

* feat(cf): init conditional format model

* fix(dev): fix dev config

* feat(cf):  mark dirty when change conditional rule

* feat(numfmt): support serial time  to timestamp

* feat(cf): support text number time operator

* feat(cf): add priority cache

* feat(cf): change cfid type to string from number

* fix(cf): diff value type

* feat(cf): add render highlightCell demo

* chore(cf): add condition format plugin to example

* feat(sheet): add skeleton update

* feat(cf): support average

* feat(cf): support rank

* feat(cf): support cell change and caculate cf

* feat(cf): add caculate cache

* feat(cf): supports rendering linkage

* feat(cf): do not empty style when markDirty

* feat(cf): support mix old style

* docs(cf): docs

* feat(cf): add base command and mutation

* style(cf): format

* fix(cf): can not move to the top

* feat(cf): add undo mutation

* fix(cf): reduce the cell sort time ,50%

* fix(cf): reduce the cost of mark dirty ,80%

* fix(cf): the interval contains the tail

* feat(cf): support data bar

* chore(cf): format code

* fix(cf): data bar suppoer gradient

* feat(cf): support color scale

* feat(ref-range): support default range change util

* feat(cf): conditional format support ref range

* fix(cf): some ref range bug

* feat(cf): conditional format support copy/paste

* feat(cf): support auto fill

* feat(cf): clear cf when sheet is deleted

* fix(cf): the target populated area needs to be cleared

* fix(cf): after each setting, the conditional format is cleared before rendering

* fix(cf): rule priority problem

* feat(cf): support panel set cf

* feat(cf): init menu

* feat(cf): support change priority

* chore(cf): rename

* feat(cf): support set/delete/move undo and redo

* feat(cf): add package config

* feat(cf): support i18n

* feat(cf): support preview

* fix(cf): new rules can not be retracted when added

* feat(cf): panel ui

* feat(cf): i18n support react node

* feat(cf): support t function nesting

* style(cf): ui fix

* fix(cf): serialTimeToTimestamp bugfix

* style(cf): ui fix

* feat(cf): support for persistence

* fix(cf): the node environment executes only the service logic, not the cleanup controller logic

* fix(cf): lint

* fix(cf): formula error

* feat(cf): support formula

* fix(formula): formulaId result

* fix(sheet): formula queue

* feat(formula): other formula dirty

* feat(cf): support formula mark dirty

* fix(sheet): other formula make dirty

* fix(cf): set default bg color is undefined

* feat(cf): support create rule from menu

* fix(cf): formula cache is not worke

* feat(cf): support absolute ref

* fix(formula): config service  ts error

* feat(cf): support formula value type

* feat(cf): reuse the last result before waiting for the result of the calculation

* feat(cf): menu support cf

* feat(formula): support batch register

* fix(formula): add batch interface

* feat(formula): batch remove

* fix(cf): support batch creation and deletion formulas are supported

* chore: delete obsolete file

* chore: delete obsolete file

* fix(cf): databar panel init state error

* chore(cf): extract the public code

* feat(cf): support icon set

* feat(cf): support pre build icon base64

* feat(cf): support icon set panel

* feat(cf): support range selector

* feat(cf): support formula editor

* fix(cf): error when folder does not exist

* feat(cf): iconSet support offset

* feat(cf): support clear conditional format

* fix(cf): add openForUnitId and openForSubUnitId

* feat(cf): add iconSet

* feat(cf): add icon group

* chore: extract scale color util

* feat(cf): preview support databar colorScale iconSet

* feat(cf): support set init range

* style(cf): ui fix

* fix(sheet): cf  recalculation can not be triggered when a date is involved

* fix(sheet): add form validation

* fix(cf): rangeSelector support placeholder

* feat(cf): clear menu support disabled

* feat(cf): update panel when change sheet

* chore: lint

* fix(cf): add i18n

* fix(cf): isShowValue is not work

* feat(cf): support iconSet menu

* fix(cf): init error

* test(cf): add highlight test case

* chore(cf): add type and doc

* chore(debugger): add sheet snapshot util

* style(cf): change default color

* test(cf): add colorscale and databar test case

* fix(cf): optimize dirty logic (#433)

* fix(cf): when previewing a number format, the conditional format style does not take effect (#439)

* fix(cf): fix checkbox error

* fix(cf): add databar min width

* fix(cf): ignore rich text

* fix(cf): some interceptors block subsequent logic execution

* fix(cf): support contains blanks

* feat(cf): support today

* fix(cf): reset formula

* wait

* fix(cf): filter abnormal settings

* fix(cf): can not modify icon set settings

* fix(cf): icon set support formula

* fix(cf): fix formula edit style

* fix(cf): verify not work when iconSet switch valueType

* fix(cf): iconset verify support formula

* fix(cf): duplicate and unique not work with p (#495)

* fix(cf): paste only the content without conditional formatting rules (#489)

* fix(cf): compose bius config (#487)

* fix(cf): different styles of icon set render different results (#485)

* fix(cf): the icon set should be above the data bar (#483)

* fix(cf): the warning prompt is in the wrong position (#480)

* fix(cf): the settings for filtering errors (#475)

* fix(cf): 0 can not be set (#472)

* fix(cf): error highlighting result of custom formula (#468)

* fix(cf): numerical calculations add type checking (#458)

* feat(cf): support clear (#433)

* feat(cf): select changes to update the rules panel(#437)

* fix(cf): 0 can not be set (#446)

* fix(cf): the style of the filter condition format is set after editing (#486)

* feat(cf): data bar gradient color adds border

* feat(cf): formula support absolute ref

* fix(cf): rule list panel were not updated in a timely manner (#437)

* feat(cf): number compare support mixed max and min

* feat(cf): support boolean compare (#461)

* fix(cf): add input validation (#454)

* feat(cf): zenZone hide cf

* fix(cf): error message does not disappear after update the icon set configuration(#480)

* test(core): add test case

* style(cf): enum should have prefix

* fix(ui): do not use hook use if logic

* style(cf): rename

* test(cf): add color scale test case

* fix(cf): not between support mixed max and min

* feat(cf): support empty icon

* style(cf): ui

---------

Co-authored-by: DR-Univer <[email protected]>
Co-authored-by: Dushusir <[email protected]>
* chore(conditional-formatting): configure package bundling setup

* docs: update README
* fix(render): media change for refresh canvas

* fix(sheet): type error

* fix(render): change to resize

* fix(render): set make force dirty
* docs: correct live demo link for zen mode

* docs: use univer.ai

* docs" update README-zh.md

---------

Co-authored-by: 白熱 <[email protected]>
* fix(formula): index function handles base value object

* fix(formula): vlookup handle array

* fix(formula): vlookup reuse function

* fix(formula): vlookup handle single value object
@DR-Univer
Copy link
Collaborator

fix-render-viewport-error 拉下来直接再上面修复就可以,没有冲突先不要rebase,1万多行的修改,开源commit要谨慎一些

@univer-bot
Copy link

univer-bot bot commented Mar 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Just pull down fix-render-viewport-error and fix it directly. If there is no conflict, don't rebase. For modifications of more than 10,000 lines, open source commits should be more cautious.

* fix(sheet): active dirty dependency ui

* fix(sheet): type error
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased

@jikkai jikkai changed the title fix operation control of frozen rows and columns will disappear when zoomed out fix: fix operation control of frozen rows and columns will disappear when zoomed out Mar 29, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 29, 2024
@wzhudev
Copy link
Member

wzhudev commented Mar 29, 2024

image

搞反了吧

@univer-bot
Copy link

univer-bot bot commented Mar 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image

It's the other way around

@jikkai jikkai closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants