Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): fix value type casting in set range values #1646

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 20, 2024

close #1637

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 20, 2024
@wzhudev wzhudev requested a review from Dushusir March 20, 2024 07:03
Copy link

github-actions bot commented Mar 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 32.82%. Comparing base (8a0bfd6) to head (76cfa5c).
Report is 37 commits behind head on dev.

Files Patch % Lines
...iscript/src/views/components/ScriptEditorPanel.tsx 0.00% 7 Missing ⚠️
...rc/commands/mutations/set-range-values.mutation.ts 83.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1646      +/-   ##
==========================================
+ Coverage   32.79%   32.82%   +0.02%     
==========================================
  Files         952      952              
  Lines       53412    53441      +29     
  Branches    11154    11170      +16     
==========================================
+ Hits        17515    17540      +25     
- Misses      35897    35901       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev requested a review from Jocs as a code owner March 20, 2024 07:59
@zhaolixin7
Copy link

@wzhudev 1、复制true&false,选择性粘贴-公式,预期显示true&false,实际显示0&1
2、下拉填充true&false,预期显示true&false,实际按1&0下拉填充
2024_3_23 18_41_14 video.webm
2024_3_23 17_40_29 commands.json

@univer-bot
Copy link

univer-bot bot commented Mar 23, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@wzhudev 1. Copy true&false, paste selectively - formula, expected to display true&false, actually displayed 0&1
2. Pull down to fill in true&false. It is expected to display true&false. In fact, press 1&0 to fill in the drop down.
2024_3_23 18_41_14 video.webm
2024_3_23 17_40_29 commands.json

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 23, 2024
@wzhudev wzhudev force-pushed the wzhudev/fix-set-range-values-type branch from d9df0aa to 76cfa5c Compare March 25, 2024 10:03
@wzhudev wzhudev requested a review from jikkai as a code owner March 25, 2024 10:03
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Mar 25, 2024
@univer-bot univer-bot bot removed the qa:rejected label Mar 25, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 1, 2024
@wzhudev wzhudev merged commit 227f5b0 into dev Apr 2, 2024
8 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-set-range-values-type branch April 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] true&false is displayed as 0&1 after pasting, but it is expected to still be displayed as true&false
4 participants