Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): support popup service #1640

Merged
merged 28 commits into from
Mar 23, 2024
Merged

feat(ui): support popup service #1640

merged 28 commits into from
Mar 23, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Mar 19, 2024

close #1566

Copy link

github-actions bot commented Mar 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 192 lines in your changes are missing coverage. Please review.

Project coverage is 32.82%. Comparing base (f30b987) to head (70c2637).
Report is 8 commits behind head on dev.

Files Patch % Lines
...eets-ui/src/services/canvas-pop-manager.service.ts 0.00% 86 Missing ⚠️
packages/sheets-ui/src/common/utils.ts 0.00% 38 Missing ⚠️
packages/design/src/components/popup/RectPopup.tsx 0.00% 33 Missing ⚠️
...src/services/popup/global-popup-manager.service.ts 0.00% 19 Missing ⚠️
...ages/ui/src/views/components/popup/GlobalPopup.tsx 0.00% 15 Missing ⚠️
packages/ui/src/views/parts.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1640      +/-   ##
==========================================
- Coverage   32.92%   32.82%   -0.11%     
==========================================
  Files         934      950      +16     
  Lines       52498    53035     +537     
  Branches    11011    11079      +68     
==========================================
+ Hits        17286    17408     +122     
- Misses      35212    35627     +415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Mar 21, 2024

Reviewing...

packages/design/src/components/popup/RectPopup.tsx Outdated Show resolved Hide resolved
packages/design/src/components/popup/RectPopup.tsx Outdated Show resolved Hide resolved
packages/design/src/components/popup/RectPopup.tsx Outdated Show resolved Hide resolved
packages/ui/src/views/components/popup/UniverPopup.tsx Outdated Show resolved Hide resolved
packages/ui/src/ui-plugin.ts Outdated Show resolved Hide resolved
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jikkai Could you please help to review the design on the RectPopup component? I am concerned about the following:

  1. Shall we implement a ClickOutside component?
  2. Could RectPopup be implemented on the top of Popup?

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 5e597fd into dev Mar 23, 2024
8 checks passed
@wzhudev wzhudev deleted the feat/canvas-popup branch March 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quick Ticket] extract a canvas popup service to provide contains to upper features
3 participants