-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): support popup service #1640
Conversation
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1640 +/- ##
==========================================
- Coverage 32.92% 32.82% -0.11%
==========================================
Files 934 950 +16
Lines 52498 53035 +537
Branches 11011 11079 +68
==========================================
+ Hits 17286 17408 +122
- Misses 35212 35627 +415 ☔ View full report in Codecov by Sentry. |
Reviewing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jikkai Could you please help to review the design on the RectPopup
component? I am concerned about the following:
- Shall we implement a
ClickOutside
component? - Could
RectPopup
be implemented on the top ofPopup
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #1566