Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): correct checkbox checked state logic for standalone usage #1627

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 18, 2024

No description provided.

@jikkai jikkai requested a review from wzhudev as a code owner March 18, 2024 12:57
Copy link

github-actions bot commented Mar 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (b03c707) to head (e5411fb).

Files Patch % Lines
...ckages/design/src/components/checkbox/Checkbox.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1627   +/-   ##
=======================================
  Coverage   32.80%   32.80%           
=======================================
  Files         928      928           
  Lines       52273    52273           
  Branches    10917    10918    +1     
=======================================
  Hits        17148    17148           
  Misses      35125    35125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 5eea109 into dev Mar 18, 2024
7 checks passed
@jikkai jikkai deleted the fix/checkbox branch March 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants