feat(sheets): support ref-range-formula-service & custom-cell-render-extension #1564
Conversation
weird94
requested review from
DR-Univer,
Dushusir,
jikkai and
wzhudev
as code owners
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1564 +/- ##
==========================================
- Coverage 32.86% 32.37% -0.49%
==========================================
Files 919 925 +6
Lines 51202 52254 +1052
Branches 10661 10903 +242
==========================================
+ Hits 16825 16917 +92
- Misses 34377 35337 +960 ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1564 +/- ##
==========================================
- Coverage 32.86% 32.79% -0.07%
==========================================
Files 919 921 +2
Lines 51202 51311 +109
Branches 10661 10686 +25
==========================================
Hits 16825 16825
- Misses 34377 34486 +109 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| // current cell is hidden | ||
| if (!worksheet.getColVisible(col) || !worksheet.getRowVisible(row)) { |
| super(); | ||
| } | ||
|
|
||
| registerFormula(formulaId: string, formula: string, callback: FormulaChangeCallback): IDisposable { |
There was a problem hiding this comment.
update-formula.controller.ts 里的逻辑有做抽象么？这里没有看到，最好是一套逻辑来维护
| import type { ICellDataForSheetInterceptor } from './i-cell-data'; | ||
| import type { ISelectionCellWithCoord } from './i-selection-data'; | ||
|
|
||
| export interface ICellRenderContext { |
There was a problem hiding this comment.
These interface may be not the most appropriate to be placed in package core.
| @@ -48,6 +49,7 @@ export interface ICellData { | |||
| export interface ICellDataForSheetInterceptor extends ICellData { | |||
| interceptorStyle?: Nullable<IStyleData>; | |||
| isInArrayFormulaRange?: Nullable<boolean>; | |||
| customRender?: Nullable<ICellCustomRender[]>; | |||
There was a problem hiding this comment.
We should provide a similar interceptor on the rendering package instead of making into core.
jikkai
changed the title
devbranch.close #