Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(base-ui): change class to function component #129

Merged
merged 7 commits into from
Sep 13, 2023
Merged

refactor(base-ui): change class to function component #129

merged 7 commits into from
Sep 13, 2023

Conversation

Dushusir
Copy link
Member

No description provided.

@wzhudev wzhudev removed their request for review September 12, 2023 02:21
@Dushusir Dushusir marked this pull request as draft September 12, 2023 02:23
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

组件的 props 和组件的实现要在同一个文件里,Interface 这样的目录以后不再有了

@Dushusir
Copy link
Member Author

组件的 props 和组件的实现要在同一个文件里,Interface 这样的目录以后不再有了

OK。剩下几个业务组件接口,待业务组件从ui-plugin-sheets迁移完后再整理。

@Dushusir Dushusir marked this pull request as ready for review September 12, 2023 12:52
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit 812f782 into dev Sep 13, 2023
3 checks passed
@jikkai jikkai deleted the ui-hooks branch September 13, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants