Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix testing tools for react #127

Merged
merged 2 commits into from
Sep 12, 2023
Merged

chore: fix testing tools for react #127

merged 2 commits into from
Sep 12, 2023

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 11, 2023 •
edited
Loading

related #123

@jikkai jikkai marked this pull request as ready for review September 11, 2023 09:10
@wzhudev
Copy link
Member

wzhudev commented Sep 11, 2023 •
edited
Loading

CI Test failed. Is that expected?

@jikkai
Copy link
Member Author

jikkai commented Sep 11, 2023

CI Test failed. Is that expected?

Yes.
We will fix the test cases of base-ui later in another pr, as well as temporarily remove the test cases of unfinished plugins

@wzhudev wzhudev merged commit 8734fb1 into dev Sep 12, 2023
2 of 3 checks passed
@jikkai jikkai deleted the test/react branch September 12, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jikkai @wzhudev