Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add textX to build and serialize actions #1256

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jan 25, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (3c67252) 29.62% compared to head (a71d8f3) 29.69%.
Report is 6 commits behind head on dev.

Files Patch % Lines
...docs/src/commands/commands/core-editing.command.ts 0.00% 13 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 6 Missing ⚠️
...es/docs/src/commands/commands/ime-input.command.ts 0.00% 6 Missing ⚠️
...es/core/src/docs/data-model/document-data-model.ts 0.00% 4 Missing ⚠️
...ackages/docs/src/commands/commands/list.command.ts 0.00% 4 Missing ⚠️
packages/core/src/docs/data-model/text-x/text-x.ts 95.74% 2 Missing ⚠️
...s/src/commands/commands/clipboard.inner.command.ts 81.81% 2 Missing ⚠️
...cs/src/commands/mutations/core-editing.mutation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1256      +/-   ##
==========================================
+ Coverage   29.62%   29.69%   +0.06%     
==========================================
  Files         829      830       +1     
  Lines       46865    46941      +76     
  Branches     9591     9601      +10     
==========================================
+ Hits        13885    13938      +53     
- Misses      28765    28788      +23     
  Partials     4215     4215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (3c67252) 29.62% compared to head (76c513c) 29.68%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...docs/src/commands/commands/core-editing.command.ts 0.00% 13 Missing ⚠️
packages/core/src/docs/data-model/text-x/text-x.ts 85.10% 7 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 6 Missing ⚠️
...es/docs/src/commands/commands/ime-input.command.ts 0.00% 6 Missing ⚠️
...es/core/src/docs/data-model/document-data-model.ts 0.00% 4 Missing ⚠️
...ackages/docs/src/commands/commands/list.command.ts 0.00% 4 Missing ⚠️
...s/src/commands/commands/clipboard.inner.command.ts 81.81% 2 Missing ⚠️
...cs/src/commands/mutations/core-editing.mutation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1256      +/-   ##
==========================================
+ Coverage   29.62%   29.68%   +0.05%     
==========================================
  Files         829      830       +1     
  Lines       46865    46930      +65     
  Branches     9591     9601      +10     
==========================================
+ Hits        13885    13931      +46     
- Misses      28765    28784      +19     
  Partials     4215     4215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Jocs Jocs marked this pull request as ready for review January 25, 2024 09:49
@Jocs Jocs merged commit 46deaf2 into dev Jan 25, 2024
8 checks passed
@Jocs Jocs deleted the reafactor/add-text-x branch January 25, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants